Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved how-to-play page #578

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Improved how-to-play page #578

merged 3 commits into from
Jul 23, 2024

Conversation

VijaySamant4368
Copy link
Contributor

@VijaySamant4368 VijaySamant4368 commented Jul 22, 2024 •
edited
Loading

PR Description 📜

Improved the how-to-play page by adding a navbar toggler

Fixes #569

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.
## Add your screenshots(Optional) 📸 ![image](https://github.com/user-attachments/assets/fbcdb4a5-bf5a-426f-99ec-4c77ebf7f180)

Thank you soo much for contributing to our repository 💗

@VijaySamant4368
Copy link
Contributor Author

image_2024-07-22_191629695

@VijaySamant4368
Copy link
Contributor Author

@ayush-t02 Please check and merge

@ayush-t02
Copy link
Collaborator

Add this hamburger to the navbar for all the pages not just one

@VijaySamant4368
Copy link
Contributor Author

@ayush-t02 many other pages don't require it.
There are no nav-bar items in these pages:

  • Licensing
  • Privacy Policy
  • Terms of Service
  • Game
  • FAQ
  • Contributors

The only page that should include the hamburger and doesn't already is about page, which I will improve right now.
Also there is a hamburger menu in the home page, with a slight error, which I will resolve.

If I have missed something, please do tell me.

@VijaySamant4368
Copy link
Contributor Author

I made the working hamburger in the About page

@ayush-t02 ayush-t02 merged commit c0f979f into ChromeGaming:main Jul 23, 2024
@VijaySamant4368
Copy link
Contributor Author

In home page, the wired behavior starts at 768px and and remains like that as we reduce the width. The webpage becomes scrollable, therefore the hamburger doesn't appear at first, but if we scroll left, we can see that the hamburger is at the far right of the nav-bar.

@VijaySamant4368
Copy link
Contributor Author

@ayush-t02 Can I get a level 3?

@ayush-t02
Copy link
Collaborator

Not for this PR

@VijaySamant4368 VijaySamant4368 deleted the how-to-play branch July 23, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VijaySamant4368 VijaySamant4368

Labels
gssoc level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unresponsive for mobile devices
2 participants
@VijaySamant4368 @ayush-t02